Skip to content

[DON'T MERGE] Rework property getting code in _assert_style_element. #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[DON'T MERGE] Rework property getting code in _assert_style_element. #522

wants to merge 2 commits into from

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Dec 17, 2013

  • Makes the code significantly easier to read.
  • Reduces duplicate code.
  • Runs through get_computed_style better.

Don't Merge - sending for feedback

@mithro
Rework property getting code in _assert_style_element.
493c34d 
 * Makes the code significantly easier to read.
 * Reduces duplicate code.
 * Runs through get_computed_style better.
@mithro
Copy link
Contributor Author

mithro commented Jan 20, 2014

Change _set_get_property to _set_property and create _get_property (which calls _set_property with nothing to set).

Fix the doc strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mithro @alancutter